test: cover Result residual conversion for Exit#201
Open
wenxiaojie1 wants to merge 2 commits into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The blanket
impl<T: Termination> From<String> for Exit<T>in the test may prevent adding a more generalFromimplementation forExitin the main crate later due to coherence rules; consider narrowing the impl (e.g., to a test-only newtype) so it cannot conflict with future library code.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The blanket `impl<T: Termination> From<String> for Exit<T>` in the test may prevent adding a more general `From` implementation for `Exit` in the main crate later due to coherence rules; consider narrowing the impl (e.g., to a test-only newtype) so it cannot conflict with future library code.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
Addressed the review: the test conversion is now limited to the actual residual type, Exit<!>, rather than applying to every Exit. This keeps the test focused on the derived Result residual path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.\n\nAdds a regression test that uses ? on Result<(), String> in a function returning the derived Exit<()>, then verifies the error is converted to Exit::OtherError. The test-local From implementation supplies the residual conversion required by the derive.\n\nValidation:\n- git diff --check\n- Confirmed the test exercises the Result ? path\n\nThe local Windows environment has no Cargo/Rust toolchain, so repository CI is the compilation and test gate.